New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: If don't specify the startup parameters, db mode don't take effect #1314
Conversation
…take effect. Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #1314 +/- ##
=============================================
+ Coverage 48.62% 48.66% +0.03%
- Complexity 1643 1644 +1
=============================================
Files 331 331
Lines 11533 11535 +2
Branches 1428 1428
=============================================
+ Hits 5608 5613 +5
+ Misses 5303 5301 -2
+ Partials 622 621 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ref #1317 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: If don't specify the startup parameters, db mode don't take effect
Ⅱ. Does this pull request fix one issue?
fix #1310
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews