Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: If don't specify the startup parameters, db mode don't take effect #1314

Merged
merged 5 commits into from Jul 25, 2019
Merged

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jul 16, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: If don't specify the startup parameters, db mode don't take effect

Ⅱ. Does this pull request fix one issue?

fix #1310

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…take effect.

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #1314 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1314      +/-   ##
=============================================
+ Coverage      48.62%   48.66%   +0.03%     
- Complexity      1643     1644       +1     
=============================================
  Files            331      331              
  Lines          11533    11535       +2     
  Branches        1428     1428              
=============================================
+ Hits            5608     5613       +5     
+ Misses          5303     5301       -2     
+ Partials         622      621       -1
Impacted Files Coverage Δ Complexity Δ
...src/main/java/io/seata/server/ParameterParser.java 55.55% <100%> (+3.55%) 6 <1> (+1) ⬆️
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.04%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cce3246...7b5ffcd. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly
Copy link
Member Author

ref #1317

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.7.1 start seata-server.sh file storeMode= db is invalid
5 participants