Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize sql join #1356

Merged
merged 8 commits into from Aug 9, 2019
Merged

optimize sql join #1356

merged 8 commits into from Aug 9, 2019

Conversation

andyqian
Copy link
Contributor

Ⅰ. Describe what this PR did

optimize sql join

@codecov-io
Copy link

codecov-io commented Jul 28, 2019

Codecov Report

Merging #1356 into develop will increase coverage by 11.2%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1356      +/-   ##
============================================
+ Coverage       34.2%   45.4%   +11.2%     
+ Complexity      2166    1662     -504     
============================================
  Files            427     345      -82     
  Lines          23175   12692   -10483     
  Branches        3248    1608    -1640     
============================================
- Hits            7926    5763    -2163     
+ Misses         14161    6281    -7880     
+ Partials        1088     648     -440
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ta/rm/datasource/exec/SelectForUpdateExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/io/seata/rm/datasource/exec/InsertExecutor.java 67.85% <0%> (+1.57%) 20 <0> (ø) ⬇️
...va/io/seata/rm/datasource/exec/DeleteExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...dec/protobuf/generated/RegisterRMRequestProto.java
.../protobuf/generated/BranchCommitResponseProto.java
.../io/seata/codec/protobuf/generated/ResultCode.java
...eata/codec/protobuf/generated/ResultCodeProto.java
...dec/protobuf/generated/GlobalRollbackResponse.java
...tobuf/generated/AbstractBranchEndRequestProto.java
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b882fbf...6338861. Read the comment docs.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title 1. optimize sql join optimize sql join Jul 30, 2019
@ujjboy ujjboy merged commit 59c6407 into apache:develop Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants