Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfect oracle keyword #1417

Merged
merged 19 commits into from
Aug 7, 2019
Merged

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

Perfect the oracle keywords according to https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Oracle-SQL-Reserved-Words.html, and sort it from A - Z.

Ⅱ. Does this pull request fix one issue?

#1413

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1417 into develop will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #1417     +/-   ##
============================================
- Coverage      45.97%   45.87%   -0.1%     
  Complexity      1672     1672             
============================================
  Files            345      345             
  Lines          12636    12662     +26     
  Branches        1596     1596             
============================================
  Hits            5809     5809             
- Misses          6169     6195     +26     
  Partials         658      658
Impacted Files Coverage Δ Complexity Δ
...urce/undo/oracle/keyword/OracleKeywordChecker.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ab1ce...99606e8. Read the comment docs.

Copy link
Contributor

@sharajava sharajava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey to me

@slievrly slievrly merged commit 4ba7f46 into apache:develop Aug 7, 2019
@l81893521 l81893521 deleted the perfect_oracle_keyword branch August 8, 2019 12:46
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants