-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perfect oracle keyword #1417
Perfect oracle keyword #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #1417 +/- ##
============================================
- Coverage 45.97% 45.87% -0.1%
Complexity 1672 1672
============================================
Files 345 345
Lines 12636 12662 +26
Branches 1596 1596
============================================
Hits 5809 5809
- Misses 6169 6195 +26
Partials 658 658
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okey to me
Ⅰ. Describe what this PR did
Perfect the oracle keywords according to https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/Oracle-SQL-Reserved-Words.html, and sort it from A - Z.
Ⅱ. Does this pull request fix one issue?
#1413
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews