Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: DefaultCoordinatorMetricsTest UT failed #1445

Merged
merged 2 commits into from Aug 20, 2019

Conversation

zhengyangyong
Copy link
Contributor

@zhengyangyong zhengyangyong commented Aug 12, 2019

Signed-off-by: zhengyangyong yangyong.zheng@qq.com

Ⅰ. Describe what this PR did

bugfix: DefaultCoordinatorMetricsTest UT failed

Ⅱ. Does this pull request fix one issue?

#1406

@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #1445 into develop will increase coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1445      +/-   ##
=============================================
+ Coverage      45.74%   46.39%   +0.64%     
- Complexity      1667     1691      +24     
=============================================
  Files            347      347              
  Lines          12713    12713              
  Branches        1589     1589              
=============================================
+ Hits            5816     5898      +82     
+ Misses          6253     6175      -78     
+ Partials         644      640       -4
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/coordinator/DefaultCoordinator.java 53.21% <0%> (+3.21%) 28% <0%> (+3%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 84.61% <0%> (+4.8%) 67% <0%> (+8%) ⬆️
...n/java/io/seata/server/metrics/MetricsManager.java 76.92% <0%> (+76.92%) 5% <0%> (+5%) ⬆️
...ava/io/seata/server/metrics/MetricsSubscriber.java 79.41% <0%> (+79.41%) 7% <0%> (+7%) ⬆️
...java/io/seata/server/metrics/MeterIdConstants.java 96.55% <0%> (+96.55%) 1% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a89f409...ffb9051. Read the comment docs.

@slievrly
Copy link
Member

asyn-committing-retry-delay = 1

Signed-off-by: zhengyangyong <yangyong.zheng@qq.com>
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title fix issues 1406 bugfix: DefaultCoordinatorMetricsTest UT failed Aug 15, 2019
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei merged commit f61382a into apache:develop Aug 20, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants