refactor: remove unnecessary code #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1490 +/- ##
============================================
+ Coverage 46.39% 46.4% +0.01%
- Complexity 1691 1692 +1
============================================
Files 347 347
Lines 12713 12713
Branches 1589 1589
============================================
+ Hits 5898 5900 +2
+ Misses 6175 6174 -1
+ Partials 640 639 -1
Continue to review full report at Codecov.
|
jsbxyyx
reviewed
Aug 20, 2019
| return defaultValue; | ||
| } | ||
| return value; | ||
| return StringUtils.isNotBlank(value) ? value : defaultValue; |
There was a problem hiding this comment.
isNotBlank == isNullOrEmpty ？？？
There was a problem hiding this comment.
isNotBlank == isNullOrEmpty ？？？
fix done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
refactor: remove unnecessary code