optimize: delay to delete the expired undo log #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1559 +/- ##
=============================================
- Coverage 46.42% 46.35% -0.08%
+ Complexity 1692 1690 -2
=============================================
Files 348 348
Lines 12723 12723
Branches 1588 1588
=============================================
- Hits 5907 5898 -9
- Misses 6177 6186 +9
Partials 639 639
Continue to review full report at Codecov.
|
xingfudeshi
reviewed
Aug 30, 2019
| @@ -459,7 +459,7 @@ public void init() { | |||
| } catch (Exception e) { | |||
| LOGGER.info("Exception undoLog deleting ... ", e); | |||
| } | |||
| },0, UNDOLOG_DELETE_PERIOD,TimeUnit.MILLISECONDS); | |||
| },3 * 60 * 1000, UNDOLOG_DELETE_PERIOD, TimeUnit.MILLISECONDS); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize delay to delete the expired undo log
Ⅱ. Does this pull request fix one issue?
fixes #1464
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews