Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: log query sql do not support oracle #1628

Merged
merged 8 commits into from Sep 16, 2019

Conversation

tq02ksu
Copy link
Contributor

@tq02ksu tq02ksu commented Sep 10, 2019

Ⅰ. Describe what this PR did

fix seata server startup failure problem, add oracle style sql for log query

Ⅱ. Does this pull request fix one issue?

fixes #1615

Ⅲ. Why don't you add test cases (unit test/integration test)?

it it similar to other sql replacement implementation, seams to be omiited.

Ⅳ. Describe how to verify it

the seata server can startup correctly

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #1628 into develop will decrease coverage by 0.03%.
The diff coverage is 14.28%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1628      +/-   ##
=============================================
- Coverage      47.25%   47.22%   -0.04%     
+ Complexity      1765     1764       -1     
=============================================
  Files            359      359              
  Lines          12999    13005       +6     
  Branches        1617     1620       +3     
=============================================
- Hits            6143     6141       -2     
- Misses          6192     6196       +4     
- Partials         664      668       +4
Impacted Files Coverage Δ Complexity Δ
...main/java/io/seata/core/store/db/LogStoreSqls.java 20.4% <14.28%> (-2.85%) 10 <1> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 50% <0%> (-0.91%) 26% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f15891...8937ba4. Read the comment docs.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei closed this Sep 10, 2019
@zjinlei zjinlei reopened this Sep 10, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title bugfix log query sql do not support oracle bugfix: log query sql do not support oracle Sep 16, 2019
@slievrly slievrly merged commit ac3b98d into apache:develop Sep 16, 2019
@tq02ksu tq02ksu deleted the bizlog-test branch September 16, 2019 06:58
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SQL returned by getQueryGlobalTransactionSQLByStatus method in LogStoreSqls doesn't support Oracle
5 participants