New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: log query sql do not support oracle #1628
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1628 +/- ##
=============================================
- Coverage 47.25% 47.22% -0.04%
+ Complexity 1765 1764 -1
=============================================
Files 359 359
Lines 12999 13005 +6
Branches 1617 1620 +3
=============================================
- Hits 6143 6141 -2
- Misses 6192 6196 +4
- Partials 664 668 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix seata server startup failure problem, add oracle style sql for log query
Ⅱ. Does this pull request fix one issue?
fixes #1615
Ⅲ. Why don't you add test cases (unit test/integration test)?
it it similar to other sql replacement implementation, seams to be omiited.
Ⅳ. Describe how to verify it
the seata server can startup correctly
Ⅴ. Special notes for reviews