Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:changing HashMap to LinkedHashMap for deterministic iterations #1802

Merged
merged 2 commits into from
Oct 23, 2019
Merged

test:changing HashMap to LinkedHashMap for deterministic iterations #1802

merged 2 commits into from
Oct 23, 2019

Conversation

contextshuffling
Copy link
Contributor

Ⅰ. Describe what this PR did

Modify HashMap to LinkedHashMap to fix #1801

Ⅱ. Does this pull request fix one issue?

fixes #1801

Ⅲ. Why don't you add test cases (unit test/integration test)?

This PR modifies a test

Ⅳ. Describe how to verify it

mvn test

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #1802 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1802   +/-   ##
==========================================
  Coverage      55.06%   55.06%           
  Complexity      2353     2353           
==========================================
  Files            421      421           
  Lines          14250    14250           
  Branches        1705     1705           
==========================================
  Hits            7847     7847           
  Misses          5680     5680           
  Partials         723      723

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cad72e...1f2f4ba. Read the comment docs.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi added the first-time contributor first-time contributor label Oct 22, 2019
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title changing HashMap to LinkedHashMap for deterministic iterations test:changing HashMap to LinkedHashMap for deterministic iterations Oct 23, 2019
@zjinlei zjinlei merged commit 07f5477 into apache:develop Oct 23, 2019
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Oct 27, 2019
* 'develop' of https://github.com/seata/seata:
  Remove deprecated JVM arguments in Java 11 (apache#1824)
  style: adjust check style (apache#1820)
  optimize: format error log (apache#1806)
  optimize: update codecov.yml (apache#1815)
  optimize: adjust codecov configuration (apache#1811)
  fix unexcepted exception can roll back (apache#1796)
  optimize: reduce unnecessary synchronized (apache#1799)
  bugfix: connectionproxy prepareStatement not in global transaction (apache#1805)
  bugfix: fix can't use select for update in oracle (apache#1780)
  test:changing HashMap to LinkedHashMap for deterministic iterations (apache#1802)
  feature:gzip compressor (apache#1460)
@slievrly slievrly added this to the 1.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test can fail if HashMap iterates in a different order
5 participants