optimize: use iterator to remove timeout future. #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cServer init exception.
Codecov Report
@@ Coverage Diff @@
## develop #1920 +/- ##
=============================================
+ Coverage 55.33% 55.35% +0.01%
- Complexity 2405 2406 +1
=============================================
Files 428 428
Lines 14365 14361 -4
Branches 1695 1694 -1
=============================================
Hits 7949 7949
+ Misses 5698 5695 -3
+ Partials 718 717 -1
|
jsbxyyx
reviewed
Nov 20, 2019
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
slievrly
approved these changes
Nov 20, 2019
helloworlde
suggested changes
Nov 20, 2019
core/src/main/java/io/seata/core/rpc/netty/AbstractRpcRemoting.java
Outdated
Show resolved
Hide resolved
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
ok,it has been modified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
1.use iterator to remove timeout future.
2.print log when load extConfiguration.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews