Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: travis-ci exceeded the maximum log length #1961

Merged
merged 2 commits into from
Nov 29, 2019
Merged

bugfix: travis-ci exceeded the maximum log length #1961

merged 2 commits into from
Nov 29, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Nov 29, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

bugfix: travis-ci exceeded the maximum log length

Ⅱ. Does this pull request fix one issue?

fix #1962

ref https://www.jianshu.com/p/3025c3814961

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #1961 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1961      +/-   ##
============================================
+ Coverage      55.29%   55.3%   +<.01%     
- Complexity      2408    2410       +2     
============================================
  Files            429     429              
  Lines          14279   14279              
  Branches        1676    1676              
============================================
+ Hits            7896    7897       +1     
- Misses          5675    5676       +1     
+ Partials         708     706       -2
Impacted Files Coverage Δ Complexity Δ
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.77% <0%> (-0.79%) 25% <0%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.41% <0%> (+0.39%) 28% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 85.02% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

@slievrly slievrly added the Do Not Merge Do not merge into develop label Nov 29, 2019
Copy link
Contributor

@long187 long187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@long187 long187 self-assigned this Nov 29, 2019
@long187 long187 added bug type: bug Category issues or prs related to bug. and removed Do Not Merge Do not merge into develop labels Nov 29, 2019
@long187 long187 added this to the 1.0 milestone Nov 29, 2019
@long187 long187 removed bug type: bug Category issues or prs related to bug. labels Nov 29, 2019
@long187 long187 merged commit dc858e4 into apache:develop Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

travis-ci exceeded the maximum log length
4 participants