Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Provides a tool for generating graphics that show the state machine execution path #1997

Merged
merged 2 commits into from Dec 18, 2019

Conversation

long187
Copy link
Contributor

@long187 long187 commented Dec 6, 2019

Ⅰ. Describe what this PR did

Provides a tool for generating graphics that show the state machine execution path

When diagnosing errors, we need to see the execution path of the state machine to find the failed node, preferably graphically

Ⅱ. Does this pull request fix one issue?

#1993

Ⅳ. Describe how to verify it

test/src/test/java/io/seata/saga/engine/db/mockserver/StateMachineDBMockServerTests.java

step one:

String graphJson = DesignerJsonTransformer.generateTracingGraphJson(stateMachineInstance);

step two:
copy graphJson value and replace data value of followen page

https://codesandbox.io/s/ggeditor-flow-registeredge-27vv0

const data = {
  nodes: [
  ],
  edges:[]
}

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #1997 into develop will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1997      +/-   ##
=============================================
- Coverage      55.55%   55.34%   -0.21%     
+ Complexity      2525     2521       -4     
=============================================
  Files            445      445              
  Lines          14848    14900      +52     
  Branches        1751     1765      +14     
=============================================
- Hits            8249     8247       -2     
- Misses          5837     5888      +51     
- Partials         762      765       +3
Impacted Files Coverage Δ Complexity Δ
...tatelang/parser/utils/DesignerJsonTransformer.java 55.08% <0%> (-24.92%) 24 <0> (ø)
...ource/sql/struct/cache/AbstractTableMetaCache.java 84.84% <0%> (-3.04%) 10% <0%> (-1%)
...in/java/io/seata/server/session/GlobalSession.java 84.54% <0%> (-0.49%) 67% <0%> (-1%)
...o/seata/server/coordinator/DefaultCoordinator.java 48.01% <0%> (-0.4%) 27% <0%> (-2%)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 63.7% <0%> (+0.8%) 24% <0%> (ø) ⬇️

@long187 long187 self-assigned this Dec 17, 2019
@long187 long187 added this to the 1.0 milestone Dec 17, 2019
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit d999938 into apache:develop Dec 18, 2019
@wangliang181230 wangliang181230 added mode: SAGA SAGA transaction mode and removed area/Saga labels Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: SAGA SAGA transaction mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants