Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: RootContext.java code style #2211

Merged
merged 2 commits into from
Jan 21, 2020

Conversation

EZKAYOTWJPRKXWCUYEEB
Copy link
Contributor

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Jan 20, 2020

Codecov Report

Merging #2211 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2211      +/-   ##
=============================================
- Coverage      54.34%   54.33%   -0.01%     
- Complexity      2491     2493       +2     
=============================================
  Files            454      454              
  Lines          14871    14864       -7     
  Branches        1749     1749              
=============================================
- Hits            8081     8077       -4     
+ Misses          6019     6018       -1     
+ Partials         771      769       -2
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/compressor/gzip/GzipUtil.java 90% <100%> (+1.11%) 5 <0> (ø) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50.19% <0%> (+0.38%) 31% <0%> (+1%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 84.61% <0%> (+0.48%) 68% <0%> (+1%) ⬆️

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 318605a into apache:develop Jan 21, 2020
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
booogu pushed a commit to booogu/seata that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants