optimize: add get local global status #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2351 +/- ##
=============================================
+ Coverage 51.75% 51.77% +0.01%
- Complexity 2695 2696 +1
=============================================
Files 517 517
Lines 16760 16760
Branches 2034 2034
=============================================
+ Hits 8674 8677 +3
+ Misses 7275 7273 -2
+ Partials 811 810 -1
|
funky-eyes
changed the title
funky-eyes
force-pushed
the
fix_status_error
branch
2 times, most recently
from
f333252
to
c103bf4
Compare
slievrly
reviewed
Mar 8, 2020
| @@ -145,8 +145,9 @@ private void rollbackTransaction(GlobalTransaction tx, Throwable ex) throws Tran | |||
| triggerAfterRollback(); | |||
| // 3.1 Successfully rolled back | |||
| throw new TransactionalExecutor.ExecutionException(tx, | |||
| tx.getStatus().equals(GlobalStatus.RollbackRetrying) ? TransactionalExecutor.Code.RollbackRetrying : | |||
| TransactionalExecutor.Code.RollbackDone, ex); | |||
| null != tx.getLocalStatus() && tx.getLocalStatus().equals(GlobalStatus.RollbackRetrying) | |||
There was a problem hiding this comment.
simplify the conditional judgment
There was a problem hiding this comment.
simplify the conditional judgment
PTAL
zjinlei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
add get local global status
Ⅱ. Does this pull request fix one issue?
#2325