optimize: optimize ZookeeperConfiguration log #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbxyyx
reviewed
Apr 15, 2020
| @@ -117,7 +117,8 @@ public String getConfig(String dataId, String defaultValue, long timeoutMills) { | |||
| try { | |||
| return future.get(timeoutMills, TimeUnit.MILLISECONDS); | |||
| } catch (Exception e) { | |||
| LOGGER.error("getConfig {} is error or timeout,return defaultValue {}", dataId, defaultValue); | |||
| LOGGER.error("getConfig {} is error or timeout,return defaultValue {},error : {}", | |||
There was a problem hiding this comment.
after comma add space?
ok,I will fix
Codecov Report
@@ Coverage Diff @@
## develop #2549 +/- ##
=============================================
- Coverage 51.43% 51.42% -0.02%
+ Complexity 2807 2806 -1
=============================================
Files 553 553
Lines 17699 17699
Branches 2089 2089
=============================================
- Hits 9103 9101 -2
Misses 7743 7743
- Partials 853 855 +2
|
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize:print the error message when getConfig from zk
Ⅱ. Does this pull request fix one issue?
optimize #2548
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews