Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix:fix Apollo configuration load fail due to camel style #2639

Merged
merged 3 commits into from May 4, 2020
Merged

bugfix:fix Apollo configuration load fail due to camel style #2639

merged 3 commits into from May 4, 2020

Conversation

withelios
Copy link
Contributor

Ⅰ. Describe what this PR did

修复因驼峰命名法导致配置apollo无法加载的bug

Ⅱ. Does this pull request fix one issue?

fixes #2627

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@zjinlei zjinlei added the first-time contributor first-time contributor label Apr 29, 2020
slievrly
slievrly reviewed Apr 30, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the camel style configuration item, which is also a binary choice after modification.

@withelios
Copy link
Contributor Author

Why not use the camel style configuration item, which is also a binary choice after modification.

seata在适配apoll时使用驼峰命名法导致 apollo-cli无法读取到配置。

apoll java cli
下面这样才会正确加载apollo配置

System.setProperty(app.id, FILE_CONFIG.getConfig(getApolloAppIdFileKey()));

@slievrly
Copy link
Member

Why not use the camel style configuration item, which is also a binary choice after modification.

seata在适配apoll时使用驼峰命名法导致 apollo-cli无法读取到配置。

apoll java cli
下面这样才会正确加载apollo配置

System.setProperty(app.id, FILE_CONFIG.getConfig(getApolloAppIdFileKey()));

it's my fault.

@withelios
Copy link
Contributor Author

Why not use the camel style configuration item, which is also a binary choice after modification.

seata在适配apoll时使用驼峰命名法导致 apollo-cli无法读取到配置。
apoll java cli
下面这样才会正确加载apollo配置

System.setProperty(app.id, FILE_CONFIG.getConfig(getApolloAppIdFileKey()));

it's my fault.

：）

@withelios withelios requested a review from slievrly April 30, 2020 10:54
@zjinlei zjinlei added this to the 1.3.0 milestone May 1, 2020
@xingfudeshi xingfudeshi changed the title bug fix Apollo configuration load fail due to camel style bugfix:fix Apollo configuration load fail due to camel style May 2, 2020
xingfudeshi
xingfudeshi approved these changes May 2, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

zjinlei
zjinlei approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 748e97a into apache:develop May 4, 2020
@objcoding objcoding mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjinlei zjinlei zjinlei approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@slievrly slievrly Awaiting requested review from slievrly

Assignees
No one assigned
Labels
first-time contributor first-time contributor
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

获取apollo配置失败
4 participants
@withelios @slievrly @zjinlei @xingfudeshi