Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: remove the unused variable #2647

Merged
merged 1 commit into from May 2, 2020

Conversation

diguage
Copy link
Contributor

@diguage diguage commented Apr 30, 2020

Remove the unused variable: result

@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #2647 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2647      +/-   ##
=============================================
- Coverage      51.25%   51.24%   -0.01%     
+ Complexity      2819     2818       -1     
=============================================
  Files            556      556              
  Lines          17803    17803              
  Branches        2101     2101              
=============================================
- Hits            9125     9124       -1     
  Misses          7818     7818              
- Partials         860      861       +1     
Impacted Files Coverage Δ Complexity Δ
.../io/seata/common/loader/EnhancedServiceLoader.java 66.84% <ø> (ø) 8.00 <0.00> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 54.63% <0.00%> (-0.52%) 28.00% <0.00%> (-1.00%)

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei changed the title Remove the unused variable optimize: remove the unused variable May 2, 2020
@zjinlei zjinlei merged commit 1425cf7 into apache:develop May 2, 2020
@diguage diguage deleted the remove-unused-variable branch May 2, 2020 13:29
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants