New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix TCC and Saga branches will also parse SQL in AbsConnectionProxy #2650
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2650 +/- ##
=============================================
+ Coverage 50.90% 50.91% +0.01%
- Complexity 2814 2815 +1
=============================================
Files 558 558
Lines 17941 17936 -5
Branches 2129 2126 -3
=============================================
Hits 9132 9132
+ Misses 7939 7937 -2
+ Partials 870 867 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SuspendedResourcesHolder should need to handle branchType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pls resolve conflicts.
Codecov Report
@@ Coverage Diff @@
## develop #2650 +/- ##
=============================================
- Coverage 50.03% 50.03% -0.01%
+ Complexity 2955 2951 -4
=============================================
Files 592 592
Lines 18995 18990 -5
Branches 2290 2288 -2
=============================================
- Hits 9505 9501 -4
+ Misses 8547 8545 -2
- Partials 943 944 +1
|
Ok,resolved. |
Ⅰ. Describe what this PR did
BugFix: fix TCC and saga branches also parse SQL in AbsConnnectionProxy
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews