Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: logger class miswrite #2749

Merged
merged 2 commits into from May 31, 2020
Merged

optimize: logger class miswrite #2749

merged 2 commits into from May 31, 2020

Conversation

dagmom
Copy link
Contributor

@dagmom dagmom commented May 30, 2020

Ⅰ. bugfix : logger class miswrite

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

clearly

Ⅴ. Special notes for reviews

@l81893521 l81893521 added first-time contributor first-time contributor module/saga saga module labels May 30, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020 •
edited

Codecov Report

Merging #2749 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2749   +/-   ##
==========================================
  Coverage      50.89%   50.89%           
  Complexity      2849     2849           
==========================================
  Files            567      567           
  Lines          18172    18172           
  Branches        2166     2166           
==========================================
  Hits            9249     9249           
  Misses          8029     8029           
  Partials         894      894
Impacted Files Coverage Δ Complexity Δ
...octrl/process/impl/CustomizeBusinessProcessor.java 53.12% <100.00%> (ø) 7.00 <1.00> (ø)

@dagmom
fix bug : logger class miswrite, habitual use IDEA 'ctrl+shift+o', la…
58176ec 
…st commit change the order of import class, now rollback.
l81893521
l81893521 approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

funky-eyes
funky-eyes approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx changed the title logger class miswrite optimize: logger class miswrite May 30, 2020
jsbxyyx
jsbxyyx approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx
Copy link
Member

jsbxyyx commented May 30, 2020 •
edited

@dagmom relation github username and email.

slievrly
slievrly approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoffeeLatte007 CoffeeLatte007 merged commit 6a66922 into apache:develop May 31, 2020
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l81893521 l81893521 l81893521 approved these changes

@slievrly slievrly slievrly approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

@jsbxyyx jsbxyyx jsbxyyx approved these changes

Assignees
No one assigned
Labels
first-time contributor first-time contributor module/saga saga module
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dagmom @codecov-commenter @jsbxyyx @l81893521 @slievrly @funky-eyes @CoffeeLatte007