-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix branchType not cleaned when consumer is in TCC mode #2914
Merged
funky-eyes
merged 7 commits into
apache:develop
from
wangliang181230:bugfix-branchType-null
Jul 23, 2020
Merged
bugfix: fix branchType not cleaned when consumer is in TCC mode #2914
funky-eyes
merged 7 commits into
apache:develop
from
wangliang181230:bugfix-branchType-null
Jul 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2914 +/- ##
=============================================
- Coverage 50.24% 50.13% -0.12%
- Complexity 3030 3045 +15
=============================================
Files 597 599 +2
Lines 19328 19409 +81
Branches 2353 2350 -3
=============================================
+ Hits 9711 9730 +19
- Misses 8652 8677 +25
- Partials 965 1002 +37 |
funky-eyes
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangliang181230
changed the title
bugfix: fix branchType must be null after
bugfix: fix branchType not cleaned when consumer is in TCC mode
Jul 22, 2020
RootContext.unbind()
booogu
reviewed
Jul 22, 2020
slievrly
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wangliang181230
added
mode: TCC
TCC transaction mode
type: bug
Category issues or prs related to bug.
labels
Oct 19, 2020
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
bugfix: fix branchType not cleaned when consumer is in TCC mode.
added some test.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews