bugfix: fix the application was configured to degrade at startup and can't be dynamically switch to upgraded #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can't be dynamically switch to upgraded Signed-off-by: slievrly <slievrly@163.com>
Codecov Report
@@ Coverage Diff @@
## develop #2929 +/- ##
=============================================
+ Coverage 56.18% 56.24% +0.05%
- Complexity 559 561 +2
=============================================
Files 57 57
Lines 3458 3458
Branches 423 423
=============================================
+ Hits 1943 1945 +2
Misses 1262 1262
+ Partials 253 251 -2
|
funky-eyes
reviewed
Jul 27, 2020
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(TccActionInterceptor.class); | ||
|
|
||
| private ActionInterceptorHandler actionInterceptorHandler = new ActionInterceptorHandler(); | ||
|
|
||
| private boolean disable = ConfigurationFactory.getInstance().getBoolean(ConfigurationKeys.DISABLE_GLOBAL_TRANSACTION, |
There was a problem hiding this comment.
DISABLE_GLOBAL_TRANSACTION 已经被订阅了，此类并未有其他需要监听处理的业务，为何不直接创建位局部变量，进行getBoolean？
There was a problem hiding this comment.
for the upgrade and downgrade functions，needs to be explicitly printed in the log.
|
经过验证，service.disableGlobalTransaction的功能，已经生效 |
funky-eyes
added
TM
| @@ -78,8 +80,9 @@ | |||
| private final String applicationId; | |||
| private final String txServiceGroup; | |||
| private final int mode; | |||
| private final boolean disableGlobalTransaction = ConfigurationFactory.getInstance().getBoolean( | |||
| private boolean disableGlobalTransaction = ConfigurationFactory.getInstance().getBoolean( | |||
|
resolve code conflicts |
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # spring/src/main/java/io/seata/spring/tcc/TccActionInterceptor.java
Signed-off-by: slievrly <slievrly@163.com> # Conflicts: # spring/src/main/java/io/seata/spring/tcc/TccActionInterceptor.java
Codecov Report
@@ Coverage Diff @@
## develop #2929 +/- ##
=============================================
- Coverage 50.41% 50.41% -0.01%
- Complexity 3124 3126 +2
=============================================
Files 594 594
Lines 19685 19700 +15
Branches 2457 2460 +3
=============================================
+ Hits 9925 9932 +7
- Misses 8755 8765 +10
+ Partials 1005 1003 -2
|
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Oct 22, 2020
…can't be dynamically switch to upgraded (apache#2929)
hicf
pushed a commit
to hicf/seata
that referenced
this pull request
Nov 15, 2020
…can't be dynamically switch to upgraded (apache#2929)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: slievrly slievrly@163.com
Ⅰ. Describe what this PR did
bugfix: fix the application was configured to degrade at startup and can't be dynamically switch to upgraded
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
before startup: service.disableGlobalTransaction=true;
after startup: service.disableGlobalTransaction=true;
Note that you need to use a configuration center that is not of file type. Dynamic configuration does not take effect when using seata-spring-boot-starter && type=file.
Ⅴ. Special notes for reviews