Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: remove set port repeatedly #3012

Merged
merged 3 commits into from Aug 19, 2020
Merged

optimize: remove set port repeatedly #3012

merged 3 commits into from Aug 19, 2020

Conversation

l81893521
Copy link
Contributor

Ⅰ. Describe what this PR did

When server starting, the port will settle twice.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@l81893521 l81893521 added this to the 1.4.0 milestone Aug 12, 2020
@l81893521 l81893521 added the module/core core module label Aug 12, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 12, 2020 •
edited

Codecov Report

Merging #3012 into develop will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3012      +/-   ##
=============================================
+ Coverage      50.15%   50.26%   +0.11%     
+ Complexity      3069     3068       -1     
=============================================
  Files            600      600              
  Lines          19491    19518      +27     
  Branches        2365     2410      +45     
=============================================
+ Hits            9775     9811      +36     
- Misses          8707     8720      +13     
+ Partials        1009      987      -22
Impacted Files Coverage Δ Complexity Δ
.../io/seata/core/rpc/netty/NettyServerBootstrap.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...dubbo/ApacheDubboTransactionPropagationFilter.java 55.00% <0.00%> (-1.42%) 8.00% <0.00%> (ø%)
...baba/AlibabaDubboTransactionPropagationFilter.java 52.38% <0.00%> (-1.28%) 8.00% <0.00%> (ø%)
...o/seata/server/storage/redis/lock/RedisLocker.java 39.84% <0.00%> (-0.64%) 12.00% <0.00%> (ø%)
...in/java/io/seata/server/session/GlobalSession.java 83.25% <0.00%> (-0.54%) 70.00% <0.00%> (ø%)
...rage/redis/store/RedisTransactionStoreManager.java 36.05% <0.00%> (-0.53%) 20.00% <0.00%> (ø%)
...java/io/seata/spring/tcc/TccActionInterceptor.java 11.36% <0.00%> (-0.27%) 2.00% <0.00%> (ø%)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 28.00% <0.00%> (-0.23%) 13.00% <0.00%> (ø%)
...ta/core/rpc/netty/AbstractNettyRemotingClient.java 17.73% <0.00%> (-0.18%) 8.00% <0.00%> (ø%)
...ta/core/rpc/netty/AbstractNettyRemotingServer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 27 more

ph3636
ph3636 approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@ph3636 ph3636 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

funky-eyes
funky-eyes approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jsbxyyx
jsbxyyx approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

slievrly
slievrly approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 921fa60 into apache:develop Aug 19, 2020
l81893521 added a commit to l81893521/seata that referenced this pull request Oct 22, 2020
@l81893521
optimize: remove set port repeatedly (apache#3012)
074d30c
@l81893521 l81893521 deleted the remove_set_port_repeatedly branch October 22, 2020 09:43
hicf pushed a commit to hicf/seata that referenced this pull request Nov 15, 2020
@l81893521 @hicf
optimize: remove set port repeatedly (apache#3012)
aedc8b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slievrly slievrly slievrly approved these changes

@funky-eyes funky-eyes funky-eyes approved these changes

@jsbxyyx jsbxyyx jsbxyyx approved these changes

@ph3636 ph3636 ph3636 approved these changes

Assignees
No one assigned
Labels
module/core core module
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@l81893521 @codecov-commenter @slievrly @funky-eyes @jsbxyyx @ph3636