-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: redis locker delete lock incomplete #3031
bugfix: redis locker delete lock incomplete #3031
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3031 +/- ##
=============================================
- Coverage 50.30% 50.29% -0.01%
+ Complexity 3070 3068 -2
=============================================
Files 600 600
Lines 19514 19513 -1
Branches 2408 2408
=============================================
- Hits 9817 9815 -2
Misses 8714 8714
- Partials 983 984 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for ph3636
Ⅰ. Describe what this PR did
fix redis locker delete lock incomplete
Ⅱ. Does this pull request fix one issue?
fixes #3029
Ⅲ. Why don't you add test cases (unit test/integration test)?
other person is change the same test cases
Ⅳ. Describe how to verify it
can delete all the lock key when has more than 3 row change in a branch session
Ⅴ. Special notes for reviews