Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: redis locker delete lock incomplete #3031

Merged

Conversation

caohdgege
Copy link
Contributor

Ⅰ. Describe what this PR did

fix redis locker delete lock incomplete

Ⅱ. Does this pull request fix one issue?

fixes #3029

Ⅲ. Why don't you add test cases (unit test/integration test)?

other person is change the same test cases

Ⅳ. Describe how to verify it

can delete all the lock key when has more than 3 row change in a branch session

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2020

Codecov Report

Merging #3031 into develop will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3031      +/-   ##
=============================================
- Coverage      50.30%   50.29%   -0.01%     
+ Complexity      3070     3068       -2     
=============================================
  Files            600      600              
  Lines          19514    19513       -1     
  Branches        2408     2408              
=============================================
- Hits            9817     9815       -2     
  Misses          8714     8714              
- Partials         983      984       +1     
Impacted Files Coverage Δ Complexity Δ
...o/seata/server/storage/redis/lock/RedisLocker.java 39.84% <0.00%> (+0.30%) 12.00 <0.00> (ø)
...torage/file/store/FileTransactionStoreManager.java 56.77% <0.00%> (-0.65%) 28.00% <0.00%> (-1.00%)

@funky-eyes funky-eyes added this to the 1.4.0 milestone Aug 17, 2020
@funky-eyes funky-eyes added first-time contributor first-time contributor module/server server module labels Aug 17, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lightClouds917 lightClouds917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ph3636 ph3636 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ph3636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store.mode=redis时,如果单个分支事务里面对多条数据操作,只能释放两条锁
6 participants