optimize: optimize recognize sql in limit and order by #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…timize_limit_order_by_sql
Codecov Report
@@ Coverage Diff @@
## develop #3212 +/- ##
=============================================
- Coverage 51.96% 51.52% -0.44%
+ Complexity 3481 3397 -84
=============================================
Files 637 621 -16
Lines 21054 20637 -417
Branches 2605 2549 -56
=============================================
- Hits 10941 10634 -307
+ Misses 9032 8949 -83
+ Partials 1081 1054 -27
|
caohdgege
reviewed
Oct 24, 2020
...parser-druid/src/main/java/io/seata/sqlparser/druid/postgresql/BasePostgresqlRecognizer.java
Outdated
Show resolved
Hide resolved
caohdgege
reviewed
Nov 3, 2020
...eata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/mysql/MySQLDeleteRecognizer.java
Show resolved
Hide resolved
funky-eyes
reviewed
Dec 22, 2020
| if (StringUtils.isNotBlank(orderBy)) { | ||
| suffix.append(orderBy); | ||
| suffix.append(" ").append(orderBy); |
There was a problem hiding this comment.
“ ” you can set it to a constant, right?
…er_by_sql # Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/DeleteExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/WhereRecognizer.java # sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/mysql/BaseMySQLRecognizer.java # sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/mysql/MySQLDeleteRecognizer.java # sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/mysql/MySQLUpdateRecognizer.java # sqlparser/seata-sqlparser-druid/src/test/java/io/seata/sqlparser/druid/MySQLDeleteRecognizerTest.java
…timize_limit_order_by_sql
…er_by_sql # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
…timize_limit_order_by_sql # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
…er_by_sql # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
…er_by_sql # Conflicts: # changes/en-us/1.5.0.md
…er_by_sql # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
|
plz modify AntlrMySQLDeleteRecognizer, AntlrMySQLSelectRecognizer, AntlrMySQLUpdateRecognizer either |
…er_by_sql # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
fixed |
…er_by_sql # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/WhereRecognizer.java # sqlparser/seata-sqlparser-druid/src/main/java/io/seata/sqlparser/druid/BaseRecognizer.java
Codecov Report
@@ Coverage Diff @@
## develop #3212 +/- ##
=============================================
- Coverage 40.75% 40.56% -0.19%
+ Complexity 3071 3070 -1
=============================================
Files 682 682
Lines 23001 23082 +81
Branches 2867 2854 -13
=============================================
- Hits 9373 9364 -9
- Misses 12752 12848 +96
+ Partials 876 870 -6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
This solution still has a problem that
and
in the
and I will refactor it in the later version.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews