-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: when mixed use of AT and TCC, AT branchs is not deleted #3296
bugfix: when mixed use of AT and TCC, AT branchs is not deleted #3296
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3296 +/- ##
=============================================
- Coverage 51.12% 51.00% -0.12%
- Complexity 3295 3297 +2
=============================================
Files 614 614
Lines 20125 20099 -26
Branches 2514 2467 -47
=============================================
- Hits 10288 10251 -37
+ Misses 8805 8796 -9
- Partials 1032 1052 +20 |
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
bugfix: when mixed use of AT and TCC, AT branchs is not deleted.
问题修复:AT和TCC混合使用时,AT分支未被及时删除。
顺便优化一下:
顺便添加上一个PR中变更过配置位置的提示,效果如下图:
Ⅱ. Does this pull request fix one issue?
fixes #3295
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews