-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: clean root context when state machine inst record failed #3323
bugfix: clean root context when state machine inst record failed #3323
Conversation
@long187 fixed, use duplicate key exception instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
public void testStateMachineRecordFailed() { | ||
|
||
// drop table to mock record exception | ||
jdbcTemplate.execute("drop table seata_state_machine_inst"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to ensure that this unit test is executed last, otherwise it will cause other unit tests to fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, use duplicate key exception instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM
…eand_RootContext_on_Exp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fixbug: SAGA模式在创建状态机实例,在存入数据库时,出现异常时,移除 xid和branchType,避免影响其他事务执行
Ⅱ. Does this pull request fix one issue?
fixed #3312
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews