Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix some comments #3702

Merged
merged 2 commits into from May 6, 2021
Merged

Conversation

cmonkey
Copy link
Contributor

@cmonkey cmonkey commented May 6, 2021

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #3658

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@funky-eyes funky-eyes added this to the 1.5.0 milestone May 6, 2021
@funky-eyes funky-eyes added the type: bug Category issues or prs related to bug. label May 6, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,请登记此pr及作者信息至changes文件夹中的两个1.5.0.md

@codecov-commenter
Copy link

Codecov Report

Merging #3702 (302b0d2) into develop (7bd0243) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 302b0d2 differs from pull request most recent head 0842020. Consider uploading reports for the commit 0842020 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3702      +/-   ##
=============================================
- Coverage      51.68%   51.66%   -0.02%     
- Complexity      3521     3523       +2     
=============================================
  Files            640      640              
  Lines          21420    21420              
  Branches        2675     2670       -5     
=============================================
- Hits           11070    11066       -4     
- Misses          9241     9251      +10     
+ Partials        1109     1103       -6     
Impacted Files Coverage Δ Complexity Δ
...io/seata/core/rpc/netty/RmNettyRemotingClient.java 39.13% <ø> (ø) 10.00 <0.00> (ø)
...source/AbstractDataSourceCacheResourceManager.java 42.85% <0.00%> (-42.86%) 1.00% <0.00%> (-1.00%)
...erver/storage/file/session/FileSessionManager.java 51.82% <0.00%> (-5.11%) 26.00% <0.00%> (-1.00%)
.../main/java/io/seata/rm/BaseDataSourceResource.java 26.41% <0.00%> (-3.78%) 9.00% <0.00%> (-2.00%)
...in/java/io/seata/server/session/GlobalSession.java 83.47% <0.00%> (+0.43%) 76.00% <0.00%> (+1.00%)
...rage/redis/store/RedisTransactionStoreManager.java 64.38% <0.00%> (+0.45%) 38.00% <0.00%> (+1.00%)
...o/seata/server/coordinator/DefaultCoordinator.java 53.02% <0.00%> (+0.46%) 29.00% <0.00%> (+1.00%)
...io/seata/core/rpc/netty/AbstractNettyRemoting.java 14.76% <0.00%> (+1.34%) 5.00% <0.00%> (ø%)
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) 12.00% <0.00%> (+1.00%)

@funky-eyes funky-eyes changed the title bugfix: fix some comments(#3658) bugfix: fix some comments May 6, 2021
@funky-eyes funky-eyes merged commit 23f4933 into apache:develop May 6, 2021
@cmonkey cmonkey deleted the feature/fix-comments branch May 7, 2021 01:27
@funky-eyes
Copy link
Contributor

由于前期Seata社区治理规范问题部分代码作者未签署CLA,可能引发社区知识产权风险问题。请所有在Seata社区贡献过代码(包含:主项目、官网、samples和多语言项目等)的 contributor 帮忙在这个链接登录github账号签署相应的开发者CLA,https://cla-assistant.io/seata/seata 。2023.1.31 未签署CLA的代码将会被rewrite,拜托大家帮忙签一下。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

注释错误
4 participants