optimize:fix typo of interval #3717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
May 10, 2021
| * you may use this to override global config of "client.rm.lock.retryInterval" | ||
| * note: 0 or negative number will take no effect(which mean fall back to global config) | ||
| * @return lock retry internal | ||
| */ | ||
| int lockRetryInternal() default 0; |
There was a problem hiding this comment.
1.5.0先不删除，先做个@deprecated ？
|
全局搜索了一下, 好像还有很多个地方要同步改一下的 |
Codecov Report
@@ Coverage Diff @@
## develop #3717 +/- ##
=============================================
- Coverage 51.88% 51.88% -0.01%
Complexity 3533 3533
=============================================
Files 639 639
Lines 21414 21414
Branches 2665 2665
=============================================
- Hits 11111 11110 -1
- Misses 9193 9194 +1
Partials 1110 1110
|
Will correct them all. |
funky-eyes
reviewed
May 11, 2021
rm-datasource/src/main/java/io/seata/rm/datasource/exec/LockRetryController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix typo of interval
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews