Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: RM did not clear XID after the local transaction threw an exception #4039

Merged
merged 3 commits into from Sep 25, 2021

Conversation

lvekee
Copy link
Contributor

@lvekee lvekee commented Sep 24, 2021

Ⅰ. Describe what this PR did

bugfix:RM fails to clear XID after throwing an exception after executing local transactions, resulting in the thread always binding the XID of the wrong request

Ⅱ. Does this pull request fix one issue?

fixes #4020.

@lvekee lvekee changed the title bugfix:RM fails to clear XID after throwing an exception after executing local transactions, resulting in the thread always binding the XID of the wrong request bugfix:RM did not clear XID after the local transaction threw an exception Sep 24, 2021
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caohdgege caohdgege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title bugfix:RM did not clear XID after the local transaction threw an exception bugfix: RM did not clear XID after the local transaction threw an exception Sep 25, 2021
@funky-eyes funky-eyes merged commit 6fa42af into apache:develop Sep 25, 2021
@funky-eyes funky-eyes added this to the 1.5.0 milestone Sep 25, 2021
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/integration integration module labels Sep 25, 2021
Pinocchio2018 pushed a commit to Pinocchio2018/seata that referenced this pull request Sep 26, 2021
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/integration integration module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RM执行本地事务抛出异常之后,没有执行清除xid,导致线程一直绑定着错误请求的xid
5 participants