Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix seata-test module UT not work #4276

Merged
merged 8 commits into from Jan 12, 2022

Conversation

anselleeyy
Copy link
Contributor

@anselleeyy anselleeyy commented Jan 9, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

seata-test 模块的单测用例无法运行,看上去失败原因是由于server模块支持了springboot-auto-configuration
这里移除server模块的seata-spring-autoconfigure-core,来解决这个问题

PS: 同时为了让test模块能够正常运行,这里先手动回滚了 #4062 这个PR的改动,需要先解决这个issue #4274

Ⅱ. Does this pull request fix one issue?

fix #4275

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #4276 (e6439bf) into develop (08ba36e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4276      +/-   ##
=============================================
- Coverage      48.78%   48.77%   -0.02%     
+ Complexity      3800     3797       -3     
=============================================
  Files            724      724              
  Lines          24220    24220              
  Branches        2968     2969       +1     
=============================================
- Hits           11816    11813       -3     
- Misses         11162    11164       +2     
- Partials        1242     1243       +1     
Impacted Files Coverage Δ
...ata/saga/statelang/parser/impl/FastjsonParser.java 43.75% <100.00%> (ø)
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) ⬇️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 80edb05 into apache:develop Jan 12, 2022
@slievrly slievrly added this to the 1.5.0 milestone Jan 12, 2022
@slievrly slievrly added the module/test test module label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/test test module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bugfix: fix seata-test module UT not work
3 participants