Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix type conversion error for mysql BIT(M) type #4474

Merged
merged 2 commits into from Mar 16, 2022

Conversation

GoodBoyCoder
Copy link
Contributor

@GoodBoyCoder GoodBoyCoder commented Mar 15, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4444

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #4474 (ab7c013) into develop (193a112) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4474      +/-   ##
=============================================
- Coverage      49.09%   49.00%   -0.10%     
+ Complexity      4032     4029       -3     
=============================================
  Files            730      730              
  Lines          25278    25280       +2     
  Branches        3126     3127       +1     
=============================================
- Hits           12411    12389      -22     
- Misses         11545    11570      +25     
+ Partials        1322     1321       -1     
Impacted Files Coverage Δ
...seata/rm/datasource/undo/AbstractUndoExecutor.java 69.01% <0.00%> (-0.99%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 50.00% <0.00%> (-6.84%) ⬇️
...erver/storage/file/session/FileSessionManager.java 52.94% <0.00%> (-1.31%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/rm-datasource rm-datasource module labels Mar 16, 2022
@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 16, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 33665d1 into apache:develop Mar 16, 2022
@GoodBoyCoder GoodBoyCoder deleted the bugfix_bit_type_undo_fail branch April 26, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AT模式下,mysql BIT(M)类型,二阶段回滚发生类型转换错误
4 participants