-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix sql exception with postgresql in module console #4661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Pls add change log.
Codecov Report
@@ Coverage Diff @@
## develop #4661 +/- ##
=============================================
+ Coverage 48.45% 48.64% +0.18%
- Complexity 4022 4043 +21
=============================================
Files 734 734
Lines 25577 25581 +4
Branches 3156 3157 +1
=============================================
+ Hits 12393 12443 +50
+ Misses 11849 11802 -47
- Partials 1335 1336 +1
|
@YSF-A Please move the change log to the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Fix the sql exception, because in postgresql, sql statement like select count(1) ... order by ... is not supported.
Ⅱ. Does this pull request fix one issue?
fixes #4658
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews