Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix sql exception with postgresql in module console #4661

Merged
merged 4 commits into from
Jun 6, 2022

Conversation

YSF-A
Copy link
Contributor

@YSF-A YSF-A commented Jun 4, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Fix the sql exception, because in postgresql, sql statement like select count(1) ... order by ... is not supported.

Ⅱ. Does this pull request fix one issue?

fixes #4658

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added this to the 1.5.2 milestone Jun 4, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pls add change log.

@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2022

Codecov Report

Merging #4661 (94cd63a) into develop (8ac7503) will increase coverage by 0.18%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4661      +/-   ##
=============================================
+ Coverage      48.45%   48.64%   +0.18%     
- Complexity      4022     4043      +21     
=============================================
  Files            734      734              
  Lines          25577    25581       +4     
  Branches        3156     3157       +1     
=============================================
+ Hits           12393    12443      +50     
+ Misses         11849    11802      -47     
- Partials        1335     1336       +1     
Impacted Files Coverage Δ
...n/src/main/java/io/seata/common/util/PageUtil.java 50.00% <50.00%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 44.48% <0.00%> (-0.41%) ⬇️
...rage/redis/store/RedisTransactionStoreManager.java 67.63% <0.00%> (+3.75%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️
...java/io/seata/server/storage/SessionConverter.java 89.09% <0.00%> (+9.09%) ⬆️
...va/io/seata/server/console/vo/GlobalSessionVO.java 55.88% <0.00%> (+33.82%) ⬆️

@YSF-A YSF-A changed the title bugfix: fix sql exception with postgresql in modul console bugfix: fix sql exception with postgresql in module console Jun 5, 2022
@slievrly
Copy link
Member

slievrly commented Jun 5, 2022

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 29d83e8 into apache:develop Jun 6, 2022
liuqiufeng pushed a commit to liuqiufeng/seata that referenced this pull request Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata v1.5.1 使用postgresql14,访问Console页面服务端报错
4 participants