-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix the exception in RedisTransactionStoreManager #4682
Conversation
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java
Show resolved
Hide resolved
server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/home/runner/work/seata/seata/server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java:737:13: 'while' is not followed by whitespace. [WhitespaceAround]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
修复RedisTransactionStoreManager中遍历Map时修改,抛出ConcurrentModificationException的问题。
Ⅱ. Does this pull request fix one issue?
fixes: #4667
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews