Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the exception in RedisTransactionStoreManager #4682

Merged
merged 4 commits into from
Jun 13, 2022
Merged

bugfix: fix the exception in RedisTransactionStoreManager #4682

merged 4 commits into from
Jun 13, 2022

Conversation

wingchi-leung
Copy link
Contributor

@wingchi-leung wingchi-leung commented Jun 12, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复RedisTransactionStoreManager中遍历Map时修改,抛出ConcurrentModificationException的问题。

Ⅱ. Does this pull request fix one issue?

fixes: #4667

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. first-time contributor first-time contributor module/server server module labels Jun 12, 2022
@funky-eyes funky-eyes added this to the 1.5.2 milestone Jun 12, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/seata/seata/server/src/main/java/io/seata/server/storage/redis/store/RedisTransactionStoreManager.java:737:13: 'while' is not followed by whitespace. [WhitespaceAround]

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit abc1b8b into apache:develop Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor module/server server module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.util.ConcurrentModificationException occured in seata server
3 participants