Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: oracle database insert value error #4696

Merged
merged 3 commits into from
Jun 21, 2022
Merged

Conversation

opelok-z
Copy link
Contributor

@opelok-z opelok-z commented Jun 15, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4719
fixes #4717

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly added this to the 1.5.2 milestone Jun 17, 2022
@slievrly
Copy link
Member

@opelok-z an issue is needed to describe the phenomenon.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #4696 (6deacef) into develop (95a89d5) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4696   +/-   ##
==========================================
  Coverage      49.29%   49.30%           
- Complexity      4087     4088    +1     
==========================================
  Files            735      735           
  Lines          25616    25616           
  Branches        3162     3162           
==========================================
+ Hits           12627    12629    +2     
+ Misses         11641    11640    -1     
+ Partials        1348     1347    -1     
Impacted Files Coverage Δ
...b/sql/distributed/lock/BaseDistributedLockSql.java 0.00% <ø> (ø)
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.02% <0.00%> (-0.74%) ⬇️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit d5fe866 into apache:develop Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error : ORA-00926: missing VALUES keyword DistributedLock insert error with oracle
3 participants