optimize : optimize logs when global commit/rollback catch an exception #4880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_timeout_not_remove
…_remove � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java � server/src/main/java/io/seata/server/session/SessionHelper.java
…_remove � Conflicts: � server/src/main/java/io/seata/server/coordinator/DefaultCoordinator.java
…_remove � Conflicts: � server/src/main/java/io/seata/server/session/SessionHelper.java
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #4880 +/- ##
============================================
+ Coverage 48.50% 48.55% +0.05%
- Complexity 4188 4194 +6
============================================
Files 764 764
Lines 26876 26877 +1
Branches 3357 3358 +1
============================================
+ Hits 13036 13051 +15
+ Misses 12453 12436 -17
- Partials 1387 1390 +3
|
slievrly
reviewed
Sep 7, 2022
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/seata/server/coordinator/DefaultCore.java
Outdated
Show resolved
Hide resolved
|
|
slievrly
changed the title
slievrly
changed the title
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
TC在 RM的commit遇到异常和返回false时的行为不一致，容易发生误解，这个pr只对日志进行优化
Ⅱ. Does this pull request fix one issue?
fixes #4879
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews