optimize: intercept insert on duplicate update statement which has no … #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…primary key and unique index
Codecov Report
@@ Coverage Diff @@
## develop #5075 +/- ##
=============================================
- Coverage 49.46% 49.42% -0.05%
+ Complexity 4128 4126 -2
=============================================
Files 734 734
Lines 26058 26061 +3
Branches 3221 3220 -1
=============================================
- Hits 12890 12880 -10
- Misses 11791 11805 +14
+ Partials 1377 1376 -1
|
|
不同数据库，对
例如：
|
funky-eyes
changed the title
zw201913
pushed a commit
to zw201913/seata
that referenced
this pull request
Nov 16, 2022
…o 1114_for_5073 * '1114_for_5073' of https://github.com/zw201913/seata: test: test support for arm64 (apache#5069) test: add AT transaction mode tests to support database data types (Oracle) (apache#4411) bugfix: fix could not intercept the sql witch has no primary and unique (apache#5078) optimize: intercept insert on duplicate update statement which has no primary key and unique index (apache#5075) optimize: support oracle date types (apache#4542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…primary key and unique index
Ⅰ. Describe what this PR did
针对主键自增且没有唯一索引值的insert on duplicate语句，由于主键自增值依赖驱动版本情况，需要再测试（#5065），1.6版本先进行拦截。后面的版本再考虑合入（https://github.com/seata/seata/pull/5044）
Ⅱ. Does this pull request fix one issue?
fixes #5007
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews