optimize: add tcc fence log clean task delay check #5089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -109,6 +109,10 @@ public void setLogTableName(String logTableName) { | |||
| */ | |||
| public void initCleanTask() { | |||
| try { | |||
| // disable clear task when cleanPeriod <= 0 | |||
| if (cleanPeriod.isZero() || cleanPeriod.isNegative()) { | |||
| return; | |||
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5089 +/- ##
=============================================
- Coverage 48.48% 48.47% -0.01%
+ Complexity 4139 4138 -1
=============================================
Files 743 743
Lines 26520 26523 +3
Branches 3294 3295 +1
=============================================
Hits 12857 12857
- Misses 12264 12267 +3
Partials 1399 1399
|
|
麻烦将pr的登记转到2.0.0的md中，该pr将合并到2.x分支 |
funky-eyes
added
module/tcc
|
@a364176773 |
|
优化的，develop分支，另外提一个的吗？ |
1 task
|
@wangliang181230 @a364176773 往 |
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
ScheduledThreadPoolExecutor#scheduleWithFixedDelay()方法中，long delay参数不能<=0，否则会抛出异常。可以对cleanPeriod做一个check, 当值<=0时，不启动clean task定时任务Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews