Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support two-stage concurrent notification execution #5118

Merged
merged 18 commits into from Apr 4, 2023

Conversation

funky-eyes
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4627

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2022

Codecov Report

Merging #5118 (8e3eb00) into 2.x (e69627d) will increase coverage by 0.17%.
The diff coverage is 29.31%.

❗ Current head 8e3eb00 differs from pull request most recent head 9072591. Consider uploading reports for the commit 9072591 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5118      +/-   ##
============================================
+ Coverage     48.73%   48.91%   +0.17%     
+ Complexity     4339     4170     -169     
============================================
  Files           778      741      -37     
  Lines         27454    26568     -886     
  Branches       3412     3305     -107     
============================================
- Hits          13380    12995     -385     
+ Misses        12677    12164     -513     
- Partials       1397     1409      +12     
Impacted Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 48.77% <0.00%> (+2.90%) ⬆️
...in/java/io/seata/server/session/SessionHelper.java 52.48% <25.00%> (-12.98%) ⬇️
...oconfigure/properties/server/ServerProperties.java 27.77% <40.00%> (-0.35%) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 47.42% <50.00%> (-1.68%) ⬇️

... and 204 files with indirect coverage changes

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@funky-eyes funky-eyes changed the base branch from develop to 2.x January 30, 2023 01:34
@funky-eyes funky-eyes added this to the 2.0.0 milestone Feb 1, 2023
@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. module/server server module labels Feb 1, 2023
/**
* The constant ENABLE_PARALLEL_HANDLE_BRANCH_KEY
*/
String ENABLE_PARALLEL_HANDLE_BRANCH_KEY = SERVER_PREFIX + "enableParallelHandleBranch";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

做成开关让用户配置,而不是默认并发,是出于什么考虑呢?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

保障如果代码有问题可以回退,后续稳定后可以考虑默认为true

@renliangyu857 renliangyu857 self-requested a review April 3, 2023 07:00
Copy link
Contributor

@renliangyu857 renliangyu857 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renliangyu857 renliangyu857 merged commit f7eba5c into apache:2.x Apr 4, 2023
7 checks passed
liuqiufeng pushed a commit to liuqiufeng/seata that referenced this pull request Apr 20, 2023
Bughue pushed a commit to Bughue/seata that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/server server module type: feature Category issues or prs related to feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants