New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support two-stage concurrent notification execution #5118
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5118 +/- ##
============================================
+ Coverage 48.73% 48.91% +0.17%
+ Complexity 4339 4170 -169
============================================
Files 778 741 -37
Lines 27454 26568 -886
Branches 3412 3305 -107
============================================
- Hits 13380 12995 -385
+ Misses 12677 12164 -513
- Partials 1397 1409 +12
|
/** | ||
* The constant ENABLE_PARALLEL_HANDLE_BRANCH_KEY | ||
*/ | ||
String ENABLE_PARALLEL_HANDLE_BRANCH_KEY = SERVER_PREFIX + "enableParallelHandleBranch"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
做成开关让用户配置,而不是默认并发,是出于什么考虑呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
保障如果代码有问题可以回退,后续稳定后可以考虑默认为true
server/src/test/java/io/seata/server/event/DefaultCoreForEventBusTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #4627
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews