Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Use Proxy.getInvocationHandler instead of reflection #5201

Merged
merged 3 commits into from Dec 26, 2022

Conversation

AlbumenJ
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Fix #5200

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@AlbumenJ
Copy link
Member Author

@a364176773 PTAL

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #5201 (4504792) into develop (083c718) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5201      +/-   ##
=============================================
- Coverage      48.47%   48.45%   -0.02%     
+ Complexity      4137     4135       -2     
=============================================
  Files            743      743              
  Lines          26517    26517              
  Branches        3294     3294              
=============================================
- Hits           12853    12848       -5     
- Misses         12263    12273      +10     
+ Partials        1401     1396       -5     
Impacted Files Coverage Δ
...in/java/io/seata/spring/util/SpringProxyUtils.java 3.70% <0.00%> (ø)
...rage/redis/store/RedisTransactionStoreManager.java 72.06% <0.00%> (-2.09%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (ø)
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (+0.63%) ⬆️
...torage/file/store/FileTransactionStoreManager.java 56.27% <0.00%> (+0.64%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title Use Proxy.getInvocationHandler instead of reflection bugfix: Use Proxy.getInvocationHandler instead of reflection Dec 26, 2022
@funky-eyes funky-eyes added module/spring spring module type: bug Category issues or prs related to bug. labels Dec 26, 2022
Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/spring spring module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JDK Relection in getAdvisedSupport cause JDK17 start failed
4 participants