Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize: Throwable#getCause once more #5208

Merged
merged 4 commits into from Jan 9, 2023
Merged

optimize: Throwable#getCause once more #5208

merged 4 commits into from Jan 9, 2023

Conversation

renliangyu857
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5119

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022 •
edited

Codecov Report

Merging #5208 (342af90) into develop (7291b41) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5208   +/-   ##
==========================================
  Coverage      48.47%   48.47%           
- Complexity      4137     4138    +1     
==========================================
  Files            743      743           
  Lines          26518    26520    +2     
  Branches        3294     3294           
==========================================
+ Hits           12854    12855    +1     
- Misses         12263    12265    +2     
+ Partials        1401     1400    -1
Impacted Files Coverage Δ
...in/java/io/seata/server/transaction/at/ATCore.java 41.17% <0.00%> (-1.25%) ⬇️
...ing/annotation/GlobalTransactionalInterceptor.java 33.33% <0.00%> (-0.19%) ⬇️
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (+0.63%) ⬆️

@funky-eyes funky-eyes changed the title optimize Throwable#getCause once more optimize: Throwable#getCause once more Dec 28, 2022
funky-eyes
funky-eyes approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added module/server server module module/spring spring module type: optimize and removed module/server server module module/spring spring module type: optimize labels Dec 28, 2022
xingfudeshi
xingfudeshi approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 0a09db2 into apache:develop Jan 9, 2023
@wangliang181230 wangliang181230 added this to the 1.7.0 milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

@l81893521 l81893521 Awaiting requested review from l81893521

Assignees
No one assigned
Labels
module/server server module module/spring spring module type: optimize
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

optimize Throwable#getCause
5 participants
@renliangyu857 @codecov-commenter @funky-eyes @xingfudeshi @wangliang181230