Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seata1.6.1,ext/apm-seata-skywalking-plugin模块在最后编译,导致首次编译打包时distribution目录下无ext子目录 #5245

Closed
1 task done
HEIBAIJIE opened this issue Jan 11, 2023 · 3 comments · Fixed by #5261

Comments

@HEIBAIJIE
Copy link
Contributor

HEIBAIJIE commented Jan 11, 2023

  • I have searched the issues of this repository and believe that this is not a duplicate.

Ⅰ. Issue Description

由于distribution模块不依赖ext/apm-seata-skywalking-plugin模块,导致distribution先于ext/apm-seata-skywalking-plugin构建。
这导致release-seata.xml中
image

的打包动作在首次构建时不会生效。
这将进一步导致Dockerfile中的这一行
ADD ext/ /seata-server/ext
在构建镜像时会报错。

这一bug在第二次构建时会消失,因为apm-seata-skywalking-plugin在上一次构建时已经打包完成了。

Ⅱ. Describe what happened

If there is an exception, please attach the exception trace:

Just paste your stack trace here!

image
image
可以看到apm-seata-skywalking-plugin晚于distribution
image

Ⅲ. Describe what you expected to happen

预期是先构建apm-seata-skywalking-plugin再构建distribution

Ⅳ. How to reproduce it (as minimally and precisely as possible)

  1. 下载1.6.1源码包。
  2. 运行 mvn -Prelease-seata -Dmaven.test.skip=true clean install -U
  3. 观察distribution/target/seata-server-1.6.1/seata,其中没有ext子目录

Ⅴ. Anything else we need to know?

建议distribution模块依赖apm-seata-skywalking-plugin模块

Ⅵ. Environment:

  • JDK version : 1.8.0_272
  • Seata version: 1.6.1
  • OS : Windows10
  • Others: maven 3.6.3
@slievrly
Copy link
Member

@HEIBAIJIE Can you submit a pr to fix this issue ?

@HEIBAIJIE
Copy link
Contributor Author

@slievrly I will submit a pr tonight.

@slievrly
Copy link
Member

@slievrly I will submit a pr tonight.

thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants