bugfix: don't remove GlobalSession when retry rollback or retry commit timeout #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Correct the comment on MySQLUndoUpdateExecutor#UPDATE_SQL_TEMPLATE (apache#5297) 2. Do not remove GlobalSession when retry rollback or retry commit timeout (apache#5293)
ZhangShiYeChina
changed the title
ZhangShiYeChina
changed the title
ZhangShiYeChina
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5298 +/- ##
=========================================
Coverage 48.51% 48.51%
- Complexity 4187 4190 +3
=========================================
Files 764 764
Lines 26880 26876 -4
Branches 3357 3357
=========================================
- Hits 13040 13039 -1
+ Misses 12451 12450 -1
+ Partials 1389 1387 -2
|
slievrly
reviewed
Feb 4, 2023
| @@ -379,9 +379,6 @@ protected void handleRetryRollbacking() { | |||
| if (ROLLBACK_RETRY_TIMEOUT_UNLOCK_ENABLE) { | |||
| rollbackingSession.clean(); | |||
| } | |||
| // Prevent thread safety issues | |||
There was a problem hiding this comment.
How does this pr fix TimeoutRollbacking ->TimeoutRollbackRetrying? I didn't get it.
slievrly
changed the title
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5297
fixes #5295