Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test[ArrayUtils,ConfigTools,MapUtil] #5309

Merged
merged 9 commits into from Feb 9, 2023

Conversation

liuqiufeng
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Add unit tests of the following classes:
添加如下类的单元测试:
io.seata.common.util.ArrayUtils
io.seata.common.util.ConfigTools
io.seata.common.util.MapUtil

Ⅱ. Does this pull request fix one issue?

fixes #5305

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #5309 (75783dd) into 2.x (207dda4) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head 75783dd differs from pull request most recent head f0bd553. Consider uploading reports for the commit f0bd553 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5309      +/-   ##
============================================
+ Coverage     48.59%   48.83%   +0.23%     
- Complexity     4195     4218      +23     
============================================
  Files           764      764              
  Lines         26870    26870              
  Branches       3352     3352              
============================================
+ Hits          13058    13122      +64     
+ Misses        12430    12372      -58     
+ Partials       1382     1376       -6     
Impacted Files Coverage Δ
...rc/main/java/io/seata/common/util/ConfigTools.java 71.18% <0.00%> (+16.94%) ⬆️
...src/main/java/io/seata/common/util/ArrayUtils.java 97.05% <0.00%> (+41.17%) ⬆️
...on/src/main/java/io/seata/common/util/MapUtil.java 95.23% <0.00%> (+95.23%) ⬆️

@funky-eyes funky-eyes added this to the 2.0.0 milestone Feb 7, 2023
@funky-eyes funky-eyes added the module/common common module label Feb 7, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lack of change log

@funky-eyes funky-eyes added the type: test test case label Feb 9, 2023
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 08f96f5 into apache:2.x Feb 9, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuqiufeng liuqiufeng deleted the 2.x_unit_test2 branch February 10, 2023 01:52
@slievrly slievrly added this to In progress in Enhance the test coverage via automation Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/common common module type: test test case
Projects
Development

Successfully merging this pull request may close these issues.

[Test] add test for common module
4 participants