Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: that keywords don't add escaped characters #5310

Merged
merged 4 commits into from Feb 7, 2023

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Feb 7, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Fixes #5500

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023

Codecov Report

Merging #5310 (f9bad41) into 2.x (33d777e) will increase coverage by 0.01%.
The diff coverage is 80.00%.

❗ Current head f9bad41 differs from pull request most recent head 3e5ec03. Consider uploading reports for the commit 3e5ec03 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5310      +/-   ##
============================================
+ Coverage     48.58%   48.59%   +0.01%     
  Complexity     4196     4196              
============================================
  Files           764      764              
  Lines         26877    26870       -7     
  Branches       3358     3352       -6     
============================================
+ Hits          13057    13058       +1     
+ Misses        12439    12430       -9     
- Partials       1381     1382       +1     
Impacted Files Coverage Δ
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 85.48% <75.00%> (+5.48%) ⬆️
...datasource/exec/mysql/MySQLUpdateJoinExecutor.java 77.07% <100.00%> (-0.57%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 60.45% <0.00%> (ø)
...er/src/main/java/io/seata/server/ServerRunner.java 65.38% <0.00%> (+15.38%) ⬆️

@slievrly slievrly added this to the 2.0.0 milestone Feb 7, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mode: AT AT transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在升级到 seata-1.6.1 的时候发现 对字段名是关键字的情况不再兼容
3 participants