Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: optimize EnhancedServiceLoader log #5315

Merged

Conversation

l81893521
Copy link
Contributor

@l81893521 l81893521 commented Feb 8, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #5255

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@slievrly slievrly changed the title bugfix: optimize EnhancedServiceLoader log optimize: optimize EnhancedServiceLoader log Feb 8, 2023
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add change in 2.x.md

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.7.0 milestone Feb 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2023

Codecov Report

Merging #5315 (5f2dc8e) into develop (8026bb6) will decrease coverage by 0.10%.
The diff coverage is 60.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5315      +/-   ##
=============================================
- Coverage      48.86%   48.77%   -0.10%     
+ Complexity      4185     4175      -10     
=============================================
  Files            743      743              
  Lines          26614    26614              
  Branches        3327     3327              
=============================================
- Hits           13006    12982      -24     
- Misses         12207    12233      +26     
+ Partials        1401     1399       -2     
Impacted Files Coverage Δ
.../io/seata/common/loader/EnhancedServiceLoader.java 57.32% <60.00%> (ø)
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 48.23% <0.00%> (-5.89%) ⬇️
...o/seata/server/session/AbstractSessionManager.java 61.19% <0.00%> (-2.99%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 59.16% <0.00%> (-1.93%) ⬇️
...in/java/io/seata/server/session/BranchSession.java 78.57% <0.00%> (-0.72%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 79.00% <0.00%> (-0.39%) ⬇️

@l81893521
Copy link
Contributor Author

add change in 2.x.md

already change in #5322

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangliang181230 wangliang181230 merged commit 8a8310c into apache:develop Feb 9, 2023
@wangliang181230
Copy link
Contributor

请再提交一个PR到 2.x 分支。

wangliang181230 pushed a commit to wangliang181230/seata that referenced this pull request Feb 9, 2023
l81893521 added a commit to l81893521/seata that referenced this pull request Mar 28, 2023
@l81893521 l81893521 deleted the bugfix_enhanced_loader_log branch March 29, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants