New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: optimize EnhancedServiceLoader log #5315
optimize: optimize EnhancedServiceLoader log #5315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add change in 2.x.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5315 +/- ##
=============================================
- Coverage 48.86% 48.77% -0.10%
+ Complexity 4185 4175 -10
=============================================
Files 743 743
Lines 26614 26614
Branches 3327 3327
=============================================
- Hits 13006 12982 -24
- Misses 12207 12233 +26
+ Partials 1401 1399 -2
|
already change in #5322 |
common/src/main/java/io/seata/common/loader/EnhancedServiceLoader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
请再提交一个PR到 |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5255
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews