New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix when TC returns RollbackFailed FailureHandler not executed #5321
Conversation
…, the custom FailureHandler is not executed. (apache#5311)
…, the custom FailureHandler is not executed. (apache#5311)
# Conflicts: # tm/src/main/java/io/seata/tm/api/TransactionalTemplate.java
…, the custom FailureHandler is not executed. (apache#5311)
case TimeoutRollbacking: | ||
case TimeoutRollbackRetrying: | ||
case TimeoutRollbacked: | ||
case RollbackRetryTimeout: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RollbackRetryTimeout 应该放在RollbackFailure那块,因为他是一个失败状态,且不会进行重试了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5321 +/- ##
=============================================
+ Coverage 48.76% 48.79% +0.03%
- Complexity 4173 4176 +3
=============================================
Files 743 743
Lines 26626 26634 +8
Branches 3327 3327
=============================================
+ Hits 12984 12996 +12
+ Misses 12241 12235 -6
- Partials 1401 1403 +2
|
…, the custom FailureHandler is not executed.(apache#5321)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onTimeoutRollback has a design flaw, so change it after merged.
Ⅰ. Describe what this PR did
fixes :#5231
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews