Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: add time info for global transaction timeout log #5323

Conversation

renliangyu857
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

在全局事务超时日志中添加全局事务开始时间及发起全局回滚的当前时间,方便用户排查是否应用是否存在异常以及优化相关参数配置
1675927307(1)

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.7.0 milestone Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #5323 (86c3973) into develop (eab8c9a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5323   +/-   ##
==========================================
  Coverage      48.80%   48.81%           
- Complexity      4176     4183    +7     
==========================================
  Files            743      743           
  Lines          26614    26614           
  Branches        3327     3327           
==========================================
+ Hits           12990    12992    +2     
- Misses         12221    12227    +6     
+ Partials        1403     1395    -8     
Impacted Files Coverage Δ
...o/seata/server/coordinator/DefaultCoordinator.java 46.96% <100.00%> (+0.80%) ⬆️
...o/seata/server/session/AbstractSessionManager.java 61.19% <0.00%> (-2.99%) ⬇️
.../java/io/seata/server/coordinator/DefaultCore.java 48.23% <0.00%> (-2.36%) ⬇️
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (+0.63%) ⬆️
...in/java/io/seata/server/session/GlobalSession.java 80.53% <0.00%> (+0.76%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 75.45% <0.00%> (+0.78%) ⬆️

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit 8026bb6 into apache:develop Feb 9, 2023
l81893521 pushed a commit to l81893521/seata that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants