optimize: add store mode,config type and registry type log info #5325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
reviewed
Feb 9, 2023
…e_registrytype_log' into optimize_add_storemode_configtype_registrytype_log
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #5325 +/- ##
=============================================
- Coverage 48.79% 48.78% -0.02%
+ Complexity 4176 4175 -1
=============================================
Files 743 743
Lines 26617 26623 +6
Branches 3327 3326 -1
=============================================
- Hits 12989 12988 -1
- Misses 12225 12236 +11
+ Partials 1403 1399 -4
|
funky-eyes
reviewed
Feb 10, 2023
config/seata-config-core/src/main/java/io/seata/config/ConfigurationFactory.java
Outdated
Show resolved
Hide resolved
...ery/seata-discovery-core/src/main/java/io/seata/discovery/registry/MultiRegistryFactory.java
Outdated
Show resolved
Hide resolved
discovery/seata-discovery-core/src/main/java/io/seata/discovery/registry/RegistryFactory.java
Outdated
Show resolved
Hide resolved
funky-eyes
added
optimize:log
module/core
…e_registrytype_log' into optimize_add_storemode_configtype_registrytype_log
l81893521
reviewed
Feb 14, 2023
...ery/seata-discovery-core/src/main/java/io/seata/discovery/registry/MultiRegistryFactory.java
Show resolved
Hide resolved
slievrly
reviewed
Feb 15, 2023
| @@ -337,7 +338,8 @@ protected void timeoutCheck() { | |||
| return false; | |||
| } | |||
|
|
|||
| LOGGER.warn("Global transaction[{}] is timeout and will be rollback,transaction begin time:{} and now:{}", globalSession.getXid(), globalSession.getBeginTime(), System.currentTimeMillis()); | |||
| LOGGER.warn("Global transaction[{}] is timeout and will be rollback,transaction begin time:{} and now:{}", globalSession.getXid(), | |||
There was a problem hiding this comment.
The annotation timeout is in milliseconds, here the log format is printed in seconds.
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…erver is starting
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5209
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews