New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add unit test for common module #5335
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #5335 +/- ##
============================================
+ Coverage 48.67% 49.00% +0.32%
- Complexity 4259 4307 +48
============================================
Files 769 769
Lines 27183 27183
Branches 3379 3379
============================================
+ Hits 13232 13320 +88
+ Misses 12562 12467 -95
- Partials 1389 1396 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Pls add change.
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
add unit test for
EnhancedServiceLoader,ExtensionDefinition,SizeUtilTest,ReflectionUtil,LowerCaseLinkHashMap,FileLoader,ObjectHolder
io.seata.common.loader.EnhancedServiceLoaderTest#testUnloadByClassAndActivateName
需要等EnhancedServiceLoader改造后才能启用Ⅱ. Does this pull request fix one issue?
fixes #5305
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews