Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: unified project version #5384

Merged
merged 1 commit into from Feb 22, 2023

Conversation

wangliang181230
Copy link
Contributor

@wangliang181230 wangliang181230 commented Feb 22, 2023

optimize: Unified version.
优化:统一维护版本号到<revision>Version.java 文件中不需要再修改版本号了。

同 develop 分支的 PR #5372

@codecov-commenter
Copy link

Codecov Report

Merging #5384 (bba0759) into 2.x (1ab95d7) will increase coverage by 0.08%.
The diff coverage is 80.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5384      +/-   ##
============================================
+ Coverage     48.49%   48.58%   +0.08%     
- Complexity     4304     4313       +9     
============================================
  Files           775      775              
  Lines         27388    27390       +2     
  Branches       3406     3406              
============================================
+ Hits          13282    13307      +25     
+ Misses        12707    12682      -25     
- Partials       1399     1401       +2     
Impacted Files Coverage Δ
.../src/main/java/io/seata/core/protocol/Version.java 47.61% <80.00%> (+40.11%) ⬆️
...ver/storage/redis/lock/RedisDistributedLocker.java 59.09% <0.00%> (-13.64%) ⬇️
...erver/storage/file/session/FileSessionManager.java 61.14% <0.00%> (-0.64%) ⬇️
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (ø)
...o/seata/server/coordinator/DefaultCoordinator.java 45.86% <0.00%> (+0.41%) ⬆️
...rage/redis/store/RedisTransactionStoreManager.java 77.89% <0.00%> (+1.79%) ⬆️
...in/java/io/seata/server/session/SessionHelper.java 65.45% <0.00%> (+1.81%) ⬆️
...ta/core/protocol/IncompatibleVersionException.java 100.00% <0.00%> (+100.00%) ⬆️

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit d1c4b78 into apache:2.x Feb 22, 2023
@wangliang181230 wangliang181230 deleted the unified-project-version branch February 22, 2023 08:24
@slievrly slievrly added this to the 2.0.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants