Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: the GlobalTransactional annotation npe issue. #5426

Merged
merged 7 commits into from Mar 13, 2023

Conversation

sunrui1225
Copy link
Contributor

@sunrui1225 sunrui1225 commented Mar 10, 2023

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix the GlobalTransactional nullpointerexception issue.

Ⅱ. Does this pull request fix one issue?

fixes #5434

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@sunrui1225 sunrui1225 changed the title resolve fence to rm fix the GlobalTransactional annotation nullpointerexception issue. Mar 11, 2023
@funky-eyes funky-eyes added this to the 2.0.0 milestone Mar 11, 2023
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/intergration-tx-api intergration-tx-api labels Mar 11, 2023
@funky-eyes funky-eyes changed the title fix the GlobalTransactional annotation nullpointerexception issue. bugfix: the GlobalTransactional annotation nullpointerexception issue. Mar 11, 2023
@funky-eyes funky-eyes changed the title bugfix: the GlobalTransactional annotation nullpointerexception issue. bugfix: the GlobalTransactional annotation npe issue. Mar 11, 2023
@slievrly
Copy link
Member

any issue related ?

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes
Copy link
Contributor

any issue related ?

spring xml方式声明的bean,在进切面的时候method读到的是接口类,而不是实现类,导致注解加到实现类上后,进切面读不到注解,而@service这类注解创建的bean就不会

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes merged commit e5169bb into apache:2.x Mar 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/intergration-tx-api intergration-tx-api type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not get the annotation @GlobalTransactional
5 participants